Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google dns provider metrics name key #1132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Jan 21, 2025

The google providers instrumented client has the name "google" and not "gcp", so no google provider metrics are currently appearing on the grafana dashboard https://github.com/Kuadrant/dns-operator/blob/main/internal/provider/google/google.go#L131

image

The google providers instrumented client has the name "google" and not "gcp", so no google provider metrics are currently appearing on the grafana dashboard https://github.com/Kuadrant/dns-operator/blob/main/internal/provider/google/google.go#L131

Signed-off-by: Michael Nairn <[email protected]>
@mikenairn mikenairn requested a review from philbrookes January 21, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant